Graphical profile problem in Mobile 2.0.3

[Thomas Fänge]

HI!

Updated to latest beta yesterday, and saw a problem while swiping through
the dives.
If you open a dive and then swipe left or right, only the first (and second
if you swipe right) dive is shown with a graphical profile. All other dives
after that is shown with an empty box (see attached picture) - even the
first dive if you swipe back to it.

Cheers,
Thomas

[Thomas Fänge]

Should add that I tested on both Android 6, 8 and 9.
It works on 2.0.3 (4.7.8.287) but fails on 4.7.8.338.
Tested on both mobile and tablet with same result.

/Thomas

Post by Thomas Fänge
HI!
Updated to latest beta yesterday, and saw a problem while swiping through
the dives.
If you open a dive and then swipe left or right, only the first (and
second if you swipe right) dive is shown with a graphical profile. All
other dives after that is shown with an empty box (see attached picture) -
even the first dive if you swipe back to it.
Cheers,
Thomas

[Jan Iversen]

Hi

Strange, to see it, I tested on my iPad and iPhone, here it works like a charm.

Could this be some kind of latency problem (that is you swipe too fast). I can in theory see a problem if profile widget does not complete drawing before the next swipe even arrives. I will try testing on my android vm.

rgds
Jan I.

Post by Thomas Fänge
Should add that I tested on both Android 6, 8 and 9.
It works on 2.0.3 (4.7.8.287) but fails on 4.7.8.338.
Tested on both mobile and tablet with same result.
/Thomas
HI!
Updated to latest beta yesterday, and saw a problem while swiping through the dives.
If you open a dive and then swipe left or right, only the first (and second if you swipe right) dive is shown with a graphical profile. All other dives after that is shown with an empty box (see attached picture) - even the first dive if you swipe back to it.
Cheers,
Thomas
<Screenshot_20180617-093214.png>
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[Thomas Fänge]

HI Jan!

Well, even waiting more than a minute, it doesn't update again.
Turning screen off and on again with a dive open doesn't help either. I can
only see the graphical profile when opening the dive from the list (and for
a second dive if I scroll left), but that's it, I never see any more
profiles - have to back up to the list and select a new dive to see it
again.
The behaviour is (at least for me on three different devices) repeatable to
100%, so my 2 cents is that this some kind of error rather than a latency
problem.

If I can help out with some logs or anything else, please let me know.

Cheers,
Thomas

Post by Jan Iversen
Hi
Strange, to see it, I tested on my iPad and iPhone, here it works like a charm.
Could this be some kind of latency problem (that is you swipe too fast). I
can in theory see a problem if profile widget does not complete drawing
before the next swipe even arrives. I will try testing on my android vm.
rgds
Jan I.
Should add that I tested on both Android 6, 8 and 9.
It works on 2.0.3 (4.7.8.287) but fails on 4.7.8.338.
Tested on both mobile and tablet with same result.
/Thomas
HI!

Post by Thomas Fänge
Updated to latest beta yesterday, and saw a problem while swiping through the dives.
If you open a dive and then swipe left or right, only the first (and
second if you swipe right) dive is shown with a graphical profile. All
other dives after that is shown with an empty box (see attached picture) -
even the first dive if you swipe back to it.
Cheers,
Thomas
<Screenshot_20180617-093214.png>
_______________________________________________

subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[Jan Iversen]

It sure sounds like a bug ! Waiting one minute is looong and that should definitively work.

I just wonder why I cannot reproduce it on my iPad (also with the beta version). I assume the beta versions for android and iOS are identical, but I will try and test the latest master later today.

If you mail me the log (with the new clipboard feature) I can check if there are something unexpected.


Rgds
Jan I

Post by Thomas Fänge
HI Jan!
Well, even waiting more than a minute, it doesn't update again.
Turning screen off and on again with a dive open doesn't help either. I can only see the graphical profile when opening the dive from the list (and for a second dive if I scroll left), but that's it, I never see any more profiles - have to back up to the list and select a new dive to see it again.
The behaviour is (at least for me on three different devices) repeatable to 100%, so my 2 cents is that this some kind of error rather than a latency problem.
If I can help out with some logs or anything else, please let me know.
Cheers,
Thomas
Hi
Strange, to see it, I tested on my iPad and iPhone, here it works like a charm.
Could this be some kind of latency problem (that is you swipe too fast). I can in theory see a problem if profile widget does not complete drawing before the next swipe even arrives. I will try testing on my android vm.
rgds
Jan I.

Post by Thomas Fänge
Should add that I tested on both Android 6, 8 and 9.
It works on 2.0.3 (4.7.8.287) but fails on 4.7.8.338.
Tested on both mobile and tablet with same result.
/Thomas
HI!
Updated to latest beta yesterday, and saw a problem while swiping through the dives.
If you open a dive and then swipe left or right, only the first (and second if you swipe right) dive is shown with a graphical profile. All other dives after that is shown with an empty box (see attached picture) - even the first dive if you swipe back to it.
Cheers,
Thomas
<Screenshot_20180617-093214.png>
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>

[Murillo Bernardes]

I have seen similar issues with profile on iOS, but not in a easily
reproducible way.

Since around e993d4f005 it seems to be working fine all the time. So
I'm guessing this is fixed on master.

I don't know what is the official channel for beta testing on Android,
and I have no idea which build you're using.

Murillo Bernardes

Post by Thomas Fänge
HI Jan!
Well, even waiting more than a minute, it doesn't update again.
Turning screen off and on again with a dive open doesn't help either. I can only see the graphical profile when opening the dive from the list (and for a second dive if I scroll left), but that's it, I never see any more profiles - have to back up to the list and select a new dive to see it again.
The behaviour is (at least for me on three different devices) repeatable to 100%, so my 2 cents is that this some kind of error rather than a latency problem.
If I can help out with some logs or anything else, please let me know.
Cheers,
Thomas

Post by Jan Iversen
Hi
Strange, to see it, I tested on my iPad and iPhone, here it works like a charm.
Could this be some kind of latency problem (that is you swipe too fast). I can in theory see a problem if profile widget does not complete drawing before the next swipe even arrives. I will try testing on my android vm.
rgds
Jan I.
Should add that I tested on both Android 6, 8 and 9.
It works on 2.0.3 (4.7.8.287) but fails on 4.7.8.338.
Tested on both mobile and tablet with same result.
/Thomas

Post by Thomas Fänge
HI!
Updated to latest beta yesterday, and saw a problem while swiping through the dives.
If you open a dive and then swipe left or right, only the first (and second if you swipe right) dive is shown with a graphical profile. All other dives after that is shown with an empty box (see attached picture) - even the first dive if you swipe back to it.
Cheers,
Thomas
<Screenshot_20180617-093214.png>

_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[Thomas Fänge]

HI Murillo,

I'm using the latest on Google Play (as beta-tester - the app was updated
there on the 15/6).
I haven't seen this before, first time I see this problem (and I'm only
using Android).

Best regards,
Thomas

Post by Murillo Bernardes
I have seen similar issues with profile on iOS, but not in a easily
reproducible way.
Since around e993d4f005 it seems to be working fine all the time. So
I'm guessing this is fixed on master.
I don't know what is the official channel for beta testing on Android,
and I have no idea which build you're using.
Murillo Bernardes

Post by Thomas Fänge
HI Jan!
Well, even waiting more than a minute, it doesn't update again.
Turning screen off and on again with a dive open doesn't help either. I

can only see the graphical profile when opening the dive from the list (and
for a second dive if I scroll left), but that's it, I never see any more
profiles - have to back up to the list and select a new dive to see it
again.

Post by Thomas Fänge
The behaviour is (at least for me on three different devices) repeatable

to 100%, so my 2 cents is that this some kind of error rather than a
latency problem.

Post by Thomas Fänge
If I can help out with some logs or anything else, please let me know.
Cheers,
Thomas

Post by Jan Iversen
Hi
Strange, to see it, I tested on my iPad and iPhone, here it works like

a charm.

Post by Thomas Fänge

Post by Jan Iversen
Could this be some kind of latency problem (that is you swipe too

fast). I can in theory see a problem if profile widget does not complete
drawing before the next swipe even arrives. I will try testing on my
android vm.

Post by Thomas Fänge

Post by Jan Iversen
rgds
Jan I.
Should add that I tested on both Android 6, 8 and 9.
It works on 2.0.3 (4.7.8.287) but fails on 4.7.8.338.
Tested on both mobile and tablet with same result.
/Thomas

Post by Thomas Fänge
HI!
Updated to latest beta yesterday, and saw a problem while swiping

through the dives.

Post by Thomas Fänge

Post by Jan Iversen

Post by Thomas Fänge
If you open a dive and then swipe left or right, only the first (and

second if you swipe right) dive is shown with a graphical profile. All
other dives after that is shown with an empty box (see attached picture) -
even the first dive if you swipe back to it.

Post by Thomas Fänge

Post by Jan Iversen

Post by Thomas Fänge
Cheers,
Thomas
<Screenshot_20180617-093214.png>

_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[j***@apache.org]

Thanks for the log and the video (what a convincing way to show a bug!).

I just loaded the google play version on my androidVM and it show the same problem, but master works

I agree with Bernardes on his assumption of where it was fixed.

@dirkh how can we get a new version (based on current master) to Thomas, so we can verify it works (and then update the beta packages) ?

Rgds
Jan I.

Post by Thomas Fänge
HI Murillo,
I'm using the latest on Google Play (as beta-tester - the app was updated there on the 15/6).
I haven't seen this before, first time I see this problem (and I'm only using Android).
Best regards,
Thomas
<Screenshot_20180617-111244.png>
I have seen similar issues with profile on iOS, but not in a easily
reproducible way.
Since around e993d4f005 it seems to be working fine all the time. So
I'm guessing this is fixed on master.
I don't know what is the official channel for beta testing on Android,
and I have no idea which build you're using.
Murillo Bernardes

Post by Thomas Fänge
HI Jan!
Well, even waiting more than a minute, it doesn't update again.
Turning screen off and on again with a dive open doesn't help either. I can only see the graphical profile when opening the dive from the list (and for a second dive if I scroll left), but that's it, I never see any more profiles - have to back up to the list and select a new dive to see it again.
The behaviour is (at least for me on three different devices) repeatable to 100%, so my 2 cents is that this some kind of error rather than a latency problem.
If I can help out with some logs or anything else, please let me know.
Cheers,
Thomas

Post by Jan Iversen
Hi
Strange, to see it, I tested on my iPad and iPhone, here it works like a charm.
Could this be some kind of latency problem (that is you swipe too fast). I can in theory see a problem if profile widget does not complete drawing before the next swipe even arrives. I will try testing on my android vm.
rgds
Jan I.
Should add that I tested on both Android 6, 8 and 9.
It works on 2.0.3 (4.7.8.287) but fails on 4.7.8.338.
Tested on both mobile and tablet with same result.
/Thomas

Post by Thomas Fänge
HI!
Updated to latest beta yesterday, and saw a problem while swiping through the dives.
If you open a dive and then swipe left or right, only the first (and second if you swipe right) dive is shown with a graphical profile. All other dives after that is shown with an empty box (see attached picture) - even the first dive if you swipe back to it.
Cheers,
Thomas
<Screenshot_20180617-093214.png>

_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>

_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>

[Dirk Hohndel]

Post by j***@apache.org
Thanks for the log and the video (what a convincing way to show a bug!).
I just loaded the google play version on my androidVM and it show the same problem, but master works
I agree with Bernardes on his assumption of where it was fixed.
@dirkh how can we get a new version (based on current master) to Thomas, so we can verify it works (and then update the beta packages) ?

I'm building it now and will push it to the beta channel in a few minutes. Typically I'd expect it to show up within the hour

/D

[j***@apache.org]

Thanks a lot (must to very very early in your TZ), would it be a lot also to make a testFlight version ?

rgds
Jan I.

Post by Dirk Hohndel

Post by j***@apache.org
Thanks for the log and the video (what a convincing way to show a bug!).
I just loaded the google play version on my androidVM and it show the same problem, but master works
I agree with Bernardes on his assumption of where it was fixed.
@dirkh how can we get a new version (based on current master) to Thomas, so we can verify it works (and then update the beta packages) ?

I'm building it now and will push it to the beta channel in a few minutes. Typically I'd expect it to show up within the hour
/D

[Dirk Hohndel]

Post by j***@apache.org
Thanks a lot (must to very very early in your TZ), would it be a lot also to make a testFlight version ?

It's 19:43 in Okinawa :-)
We just returned from dinner...

I can do a new TestFlight one as well. That often takes a lot longer to show up, so no promise that this will be done today.

/D

[j***@apache.org]

Ooh forgot you are man of the world, as I used to be.

Thanks for making the testFlight, it is not really important if it is today or tomorrow.

[Dirk Hohndel]

The bad news is that a build from latest master doesn't fix the problem. So chances are it's something that is weird here on my system - since you said it works for you.
Which Qt version do you build against for Android?

/D

Post by j***@apache.org
Ooh forgot you are man of the world, as I used to be.
Thanks for making the testFlight, it is not really important if it is today or tomorrow.

[Jan Iversen]

Qt 5.10....but I build a bit untraditionally, because I use my mac. Could also be a matter of the SDK/NDK versions because I forgot that I am testing an upgrade.

rgds
jan i

Enviado desde mi iPad

Post by Dirk Hohndel
The bad news is that a build from latest master doesn't fix the problem. So chances are it's something that is weird here on my system - since you said it works for you.
Which Qt version do you build against for Android?
/D

Post by j***@apache.org
Ooh forgot you are man of the world, as I used to be.
Thanks for making the testFlight, it is not really important if it is today or tomorrow.

[Dirk Hohndel]

Post by Jan Iversen
Qt 5.10....but I build a bit untraditionally, because I use my mac. Could also be a matter of the SDK/NDK versions because I forgot that I am testing an upgrade.

So the official binaries are built on ArchLinux using NDK 14b and the current SDK 3859397.
QT 5.10.1 and everything rebuilt from scratch to make sure there aren't any weird old binary issues.

Hmm - I hate debugging such random "it just stopped working" situations. Especially if it works for someone else with the same sources :-(

/D

[j***@apache.org]

Post by Dirk Hohndel

Post by Jan Iversen
Qt 5.10....but I build a bit untraditionally, because I use my mac. Could also be a matter of the SDK/NDK versions because I forgot that I am testing an upgrade.

So the official binaries are built on ArchLinux using NDK 14b and the current SDK 3859397.
QT 5.10.1 and everything rebuilt from scratch to make sure there aren't any weird old binary issues.

My SDK/NDK is newer, I will try to get around building with the release versions, hopefully later today.

If I can reproduce it, I can do bisect relative easy.

Post by Dirk Hohndel
Hmm - I hate debugging such random "it just stopped working" situations. Especially if it works for someone else with the same sources :-(

And not to forget, also not on iOS.

rgds
Jan I.

Post by Dirk Hohndel
/D

[Dirk Hohndel]

Post by j***@apache.org
Ooh forgot you are man of the world, as I used to be.
Thanks for making the testFlight, it is not really important if it is today or tomorrow.

It should be available now - things went quickly today.
Since I didn't bring any iOS devices on this trip, can you please test and make sure this isn't completely broken?

/D

[j***@apache.org]

Post by Dirk Hohndel

Post by j***@apache.org
Ooh forgot you are man of the world, as I used to be.
Thanks for making the testFlight, it is not really important if it is today or tomorrow.

It should be available now - things went quickly today.
Since I didn't bring any iOS devices on this trip, can you please test and make sure this isn't completely broken?

Downloading (which is rather slow) as we speak, I got the notification from apple 2 minutes before your email.

rgds
Jan I.

[Murillo Bernardes]

I just tried the new version on iOS.

Interesting enough, the error reported here is now 100% reproducible
when using my ~500 imported dives logbook.

Looks like the profile changes actually messed something I could not
see with my small test logbook.


Murillo Bernardes

Post by Dirk Hohndel

Post by j***@apache.org
Ooh forgot you are man of the world, as I used to be.
Thanks for making the testFlight, it is not really important if it is today or tomorrow.

It should be available now - things went quickly today.
Since I didn't bring any iOS devices on this trip, can you please test and make sure this isn't completely broken?
/D
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[Dirk Hohndel]

Post by Murillo Bernardes
I just tried the new version on iOS.
Interesting enough, the error reported here is now 100% reproducible
when using my ~500 imported dives logbook.
Looks like the profile changes actually messed something I could not
see with my small test logbook.

Crud. Does it happen with your locally compiled version as well or only with
my build?

/D

[Murillo Bernardes]

Yes, it does. I didn't notice before because I was checking for
something similar but not exactly the same.

Your build is fine. Master is really broken here.

Murillo Bernardes

Post by Dirk Hohndel

Post by Murillo Bernardes
I just tried the new version on iOS.
Interesting enough, the error reported here is now 100% reproducible
when using my ~500 imported dives logbook.
Looks like the profile changes actually messed something I could not
see with my small test logbook.

Crud. Does it happen with your locally compiled version as well or only with
my build?
/D

[Dirk Hohndel]

Post by Murillo Bernardes
Yes, it does. I didn't notice before because I was checking for
something similar but not exactly the same.
Your build is fine. Master is really broken here.

Someone should try to bisect this :-)

/D

[j***@apache.org]

Post by Dirk Hohndel

Post by Murillo Bernardes
Yes, it does. I didn't notice before because I was checking for
something similar but not exactly the same.
Your build is fine. Master is really broken here.

Someone should try to bisect this :-)

“Someone” == jani. Will start right away.

rgds
Jan I

Post by Dirk Hohndel
/D

[Murillo Bernardes]

Jan, I believe just reverting e993d4f005e62c12765e2e45342ecf840476e3bf
should do it.

Murillo Bernardes

[j***@apache.org]

I came to the same conclusion, but did not read your mail until now.

That is my commit, and I would like to revert it in a way that keeps the functionality (no plotDive calls during startup).

Give me a couple of hours.

rgds
Jan I.

Post by Murillo Bernardes
Jan, I believe just reverting e993d4f005e62c12765e2e45342ecf840476e3bf
should do it.
Murillo Bernardes

[j***@apache.org]

I hope problem is solved with #1393.

Big thanks to Bernardes who isolated the faulty commit in parallel with me. This is how a community works 1+1 = 3.

I put the real solution (changing the qml interface) on my todo list, since I am anyhow nearly complete with a v2.0 of qml variable referencing in a safe way.

rgds
Jan I.

Post by j***@apache.org
I came to the same conclusion, but did not read your mail until now.
That is my commit, and I would like to revert it in a way that keeps the functionality (no plotDive calls during startup).
Give me a couple of hours.
rgds
Jan I.

Post by Murillo Bernardes
Jan, I believe just reverting e993d4f005e62c12765e2e45342ecf840476e3bf
should do it.
Murillo Bernardes

[Dirk Hohndel]

Post by j***@apache.org
I hope problem is solved with #1393.

That's the one adding the dark GPS icon. Don't you mean #1397?

Post by j***@apache.org
Big thanks to Bernardes who isolated the faulty commit in parallel with me. This is how a community works 1+1 = 3.

Indeed. Thanks to both of you

Post by j***@apache.org
I put the real solution (changing the qml interface) on my todo list, since I am anyhow nearly complete with a v2.0 of qml variable referencing in a safe way.

Looking forward to that. :-)

/D

[Thomas Fänge]

Yes, thanks, problem is gone from the latest app version 😊

Best regards,
Thomas

Post by j***@apache.org
I hope problem is solved with #1393.
Big thanks to Bernardes who isolated the faulty commit in parallel with
me. This is how a community works 1+1 = 3.
I put the real solution (changing the qml interface) on my todo list,
since I am anyhow nearly complete with a v2.0 of qml variable referencing
in a safe way.
rgds
Jan I.

Post by j***@apache.org
I came to the same conclusion, but did not read your mail until now.
That is my commit, and I would like to revert it in a way that keeps the

functionality (no plotDive calls during startup).

Post by j***@apache.org
Give me a couple of hours.
rgds
Jan I.

Post by Murillo Bernardes
Jan, I believe just reverting e993d4f005e62c12765e2e45342ecf840476e3bf
should do it.
Murillo Bernardes

_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[j***@apache.org]

Yes now it happens 100%, seems the build I had running on my mobile was a bit older (with all my patches).

We do have a problem on master !

I will try to do some debugging in a while.

rgds
Jan I.

Post by Thomas Fänge
profile