Filtering on mobile

[Dirk Hohndel]

For those of you on Android, there's now a test binary available:

http://subsurface-divelog.org/downloads/test/Subsurface-mobile-4.8.3.264-arm.apk

There are still a few open issues with this, which is why I'm not pushing it to Google Play and TestFlight, yet. But I'd love to get more feedback from this group in the meantime.

Usage should be self explanatory.
tap on the new filter icon on the left side of the action button on the dive list
enter your search term, hit return on the virtual keyboard
you should see the filtered list with a number of matching dives shown in the filter entry line
the number of dives per trip is still showing the unfiltered number - that's one of the things I need to fix
tapping the filter icon again resets things

/D

[Dirk Hohndel]

Since I hand implemented the filter, I think that yes, that's the string we filter for.
Can you show an example?

/D

The feature works well for most searches filtering on tags, dive site
and buddy/divemaster. The only glitch that I find is that, in some
searches, non-target dives are included in the filtered divelist. Are
we
100% sure that the filter text at the top of the screen is really what
is used for filtering? This is a problem that I have seen once or twice
in the past in Android, that is, the displayed string not necessarily
matching the internal representation. I do not see anything in the
Android log file that provides a clue as to the problem.
Kind regards,
willem
http://subsurface-divelog.org/downloads/test/Subsurface-mobile-4.8.3.264-arm.apk

Post by Dirk Hohndel
There are still a few open issues with this, which is why I'm not

pushing it to Google Play and TestFlight, yet. But I'd love to get more
feedback from this group in the meantime.

Post by Dirk Hohndel
Usage should be self explanatory.
tap on the new filter icon on the left side of the action button on

the dive list

Post by Dirk Hohndel
enter your search term, hit return on the virtual keyboard
you should see the filtered list with a number of matching dives

shown in the filter entry line

Post by Dirk Hohndel
the number of dives per trip is still showing the unfiltered number -

that's one of the things I need to fix

Post by Dirk Hohndel
tapping the filter icon again resets things
/D
_______________________________________________
subsurface mailing list

http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
--
This message and attachments are subject to a disclaimer.
Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full
details.

[Dirk Hohndel]

Post by Dirk Hohndel
Since I hand implemented the filter, I think that yes, that's the string we filter for.
Can you show an example?
/D

The question is, of course, if the dives that don't have Sodwana in their trip location, mention
Sodwana anywhere else, e.g. as tag or in the Notes (if you have that enabled in the settings),
etc.

After all, this is a full text filter (and you can pick in the settings if it is case sensitive and if the
notes are included in the search). Does this explain the behavior?

/D

[Dirk Hohndel]

Oh, and which locale is your device running in?
I notice that the plural strings aren't adjusted, which
means that we don't have a translation for your locale.

/D

[Willem Ferguson]

From phone. Language = English (South Africa). Not sure if this is the
locale.
Kind regards
Willem

Post by Dirk Hohndel
Oh, and which locale is your device running in?
I notice that the plural strings aren't adjusted, which
means that we don't have a translation for your locale.
/D
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[Willem Ferguson]

Post by Dirk Hohndel
Oh, and which locale is your device running in?
I notice that the plural strings aren't adjusted, which
means that we don't have a translation for your locale.
/D

EN-ZA on Android

Is there anything that I (or anyone else) could do to to fix this at
least minimally?

There is the same problem with Linux and probably all OSs.

Kind regards,

willem

[Dirk Hohndel]

Post by Willem Ferguson

Post by Dirk Hohndel
Oh, and which locale is your device running in?
I notice that the plural strings aren't adjusted, which
means that we don't have a translation for your locale.
/D

EN-ZA on Android
Is there anything that I (or anyone else) could do to to fix this at least minimally?
There is the same problem with Linux and probably all OSs.

Relatively easy to do. We just need to add a "translation" for en_ZA so that the plurals are
handled. I'll add that to my backlog :-)

/D

[Dirk Hohndel]

Post by Dirk Hohndel

Post by Willem Ferguson

Post by Dirk Hohndel
Oh, and which locale is your device running in?
I notice that the plural strings aren't adjusted, which
means that we don't have a translation for your locale.
/D

EN-ZA on Android
Is there anything that I (or anyone else) could do to to fix this at least minimally?
There is the same problem with Linux and probably all OSs.

Relatively easy to do. We just need to add a "translation" for en_ZA so that the plurals are
handled. I'll add that to my backlog :-)

This was actually really easy, so I created a PR:
https://github.com/Subsurface-divelog/subsurface/pull/1825

/D

[Willem Ferguson]

Post by Dirk Hohndel
The question is, of course, if the dives that don't have Sodwana in
their trip location, mention
Sodwana anywhere else, e.g. as tag or in the Notes (if you have that
enabled in the settings),
etc.
After all, this is a full text filter (and you can pick in the
settings if it is case sensitive and if the
notes are included in the search). Does this explain the behavior?

Dirk, of course you are absolutely correct. The search term was
contained in one of the notes on a dive trip. I assumed that the notes
field is not included in the search scope. Three points:

1) It would make the search facility more useful if there was an option
to turn off including the notes in the search scope. Including the notes
within the search scope has a significant use in its own right, but I
suspect that by far the majority of searches would not involve interest
in the dive notes but would rather focus on dives with a specific buddy
or at a dive site or using specific suit or dive mode (e.g. OC, CCR).

2) I suspect the filter does not allow searching by date?

3) I have noticed a small bug in the filter text at the top of the
screen but I am struggling to re-generate this issue. I am looking at a
reliable way to generate this and I will report in a separate mail.

This is an impressive facility in the mobile version.

Kind regards,

willem

[Dirk Hohndel]

Post by Dirk Hohndel
The question is, of course, if the dives that don't have Sodwana in their trip location, mention
Sodwana anywhere else, e.g. as tag or in the Notes (if you have that enabled in the settings),
etc.
After all, this is a full text filter (and you can pick in the settings if it is case sensitive and if the
notes are included in the search). Does this explain the behavior?

You can turn that off in the settings.

1) It would make the search facility more useful if there was an option to turn off including the notes in the search scope. Including the notes within the search scope has a significant use in its own right, but I suspect that by far the majority of searches would not involve interest in the dive notes but would rather focus on dives with a specific buddy or at a dive site or using specific suit or dive mode (e.g. OC, CCR).

Yes. Go to Settings, scroll down to "Filter preferences" and turn off inclusion of the notes

2) I suspect the filter does not allow searching by date?

No it does not. Since the dive list is ordered by date, that seemed unnecessary. Is there a scenario that I'm missing?

3) I have noticed a small bug in the filter text at the top of the screen but I am struggling to re-generate this issue. I am looking at a reliable way to generate this and I will report in a separate mail.
This is an impressive facility in the mobile version.

Thanks. And yes, please keep testing and report any oddities that you find.

/D

[Willem Ferguson]

Post by Dirk Hohndel
Since I hand implemented the filter, I think that yes, that's the
string we filter for.
Can you show an example?
/D

See attached screendump. If required you are more than welcome to use
the cloud dive log at ***@gmail.com for testing purposes.

Kind regards,

willem