Discussion:
planning for 4.8.2
Dirk Hohndel
2018-09-05 20:32:20 UTC
Permalink
I think we have a few potential issues that need to be resolved - the current disagreements over how to best handle settings, preferences, etc might cause us issues that I don't want to expose our user base to.
That said, we have a nice set of new features, of course including very decent support for the Garmin Descent Mk1:

- Mac: include the FTDI driver and no longer require Mac FTDI drivers to be installed
- Desktop: allow buddies to be shown in the divelist [#1587]
- Windows: write log files to the user path instead of the path where Subsurface
is installed.
- Desktop: fix issue with dive list row height in case of larger fonts [#1600]
- Desktop: fix a bug where it is possible for the user to hide all divelist columns [#1600]
- Desktop/Export: fix bug related to quoted text when exporting to HTML [#1576]
- Desktop/Map-Widget: add support for filtering of map locations [#1581]
- Mac: fix problem downloading from divelogs.de
- Dive media: paint duration of videos on thumbnails in the dive-photo tab
- Dive media: extract video thumbnails using ffmpeg
- Dive media: implement "open folder of selected media files" [#1514]
- Dive media: show play-time of videos on the profile plot
- Dive media: draw thumbnails on top of deco-ceilings
- Dive media: Change term "photos" and "images" everywhere in the UI to "media files"
- Dive media: experimental support for metadata extraction from AVI and WMV files
- Dive media: sort thumbnails by timestamp
- Dive media: don't recalculate all pictures on drag & drop
- Profile: immediately update thumbnail positions on deletion

I will push the latest strings to Transifex in a moment. But I expect that (as always) there might be a few more coming.
In the meantime I'd like to create a punch list of what we need to address before a release

- Settings/Preferences: make sure that we are in a sane state (purely from an end user perspective - let's not restart the arguments about the implementation here)
- Translations
- Documentation: any changes needed?
- reports of crashes - I tried to ping the people reporting those to get an update... if you can make Subsurface crash, please comment here

What else should be on this list?

/D
Lubomir I. Ivanov
2018-09-06 03:08:35 UTC
Permalink
Post by Dirk Hohndel
- Documentation: any changes needed?
the new `Dive media:` features have experimental state. up for a
discussion, if we want to document this feature in the next version or
in the near future.
/cc Berthold and Willem on this topic.

lubomir
--
Berthold Stoeger
2018-09-06 04:55:35 UTC
Permalink
Hi,
Post by Lubomir I. Ivanov
Post by Dirk Hohndel
- Documentation: any changes needed?
the new `Dive media:` features have experimental state. up for a
discussion, if we want to document this feature in the next version or
in the near future.
It is quite user visible owing to the rewording. Hence I believe that it would
be preferable to document it. But last time I tried I gave up once I realized
how much work it is going be. :(

Berthold
Willem Ferguson
2018-09-07 06:49:44 UTC
Permalink
From phone (at dive site). Just give me either a mind map, a list of
features or a telegram-style shorthand version or a combination of these. I
will write full text while testing out the features on my computer,
inserting images where necessary. Kind regards, willem
Post by Berthold Stoeger
Hi,
Post by Lubomir I. Ivanov
Post by Dirk Hohndel
- Documentation: any changes needed?
the new `Dive media:` features have experimental state. up for a
discussion, if we want to document this feature in the next version or
in the near future.
It is quite user visible owing to the rewording. Hence I believe that it would
be preferable to document it. But last time I tried I gave up once I realized
how much work it is going be. :(
Berthold
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Berthold Stoeger
2018-09-08 07:39:08 UTC
Permalink
Hi Willem,
Post by Willem Ferguson
From phone (at dive site). Just give me either a mind map, a list of
features or a telegram-style shorthand version or a combination of these. I
will write full text while testing out the features on my computer,
inserting images where necessary. Kind regards, willem
seems like mails to you are bouncing:

***@zoology.up.ac.za
aspmx.l.google.com
Remote Server returned '<aspmx.l.google.com #5.0.0 smtp; 550-5.2.1 The email
account that you tried to reach is disabled. Learn more at 550 5.2.1 https://
support.google.com/mail/?p=DisabledUser b6-v6si10115859wrm.186 - gsmtp>'

Does that only concern mails from my provider?

Berthold
Willem Ferguson
2018-09-06 08:53:36 UTC
Permalink
Post by Lubomir I. Ivanov
Post by Dirk Hohndel
- Documentation: any changes needed?
the new `Dive media:` features have experimental state. up for a
discussion, if we want to document this feature in the next version or
in the near future.
/cc Berthold and Willem on this topic.
lubomir
--
I would be more than happy to generate documentation with Berthold.

Kind regards,

willem
--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full
details.
Berthold Stoeger
2018-09-06 20:20:20 UTC
Permalink
Hi Willem,
Post by Willem Ferguson
Post by Lubomir I. Ivanov
Post by Dirk Hohndel
- Documentation: any changes needed?
the new `Dive media:` features have experimental state. up for a
discussion, if we want to document this feature in the next version or
in the near future.
/cc Berthold and Willem on this topic.
lubomir
--
I would be more than happy to generate documentation with Berthold.
Thank you - If you wish I can try to sketch out the basics over the weekend.

Berthold
Willem Ferguson
2018-09-06 20:55:47 UTC
Permalink
Please do, Berthold.
Kind regards, wf
Post by Berthold Stoeger
Hi Willem,
Post by Willem Ferguson
Post by Lubomir I. Ivanov
Post by Dirk Hohndel
- Documentation: any changes needed?
the new `Dive media:` features have experimental state. up for a
discussion, if we want to document this feature in the next version or
in the near future.
/cc Berthold and Willem on this topic.
lubomir
--
I would be more than happy to generate documentation with Berthold.
Thank you - If you wish I can try to sketch out the basics over the weekend.
Berthold
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Dirk Hohndel
2018-09-07 21:50:27 UTC
Permalink
So far we had some discussion regarding documentation (which is excellent - the dive media certainly needs documentation update, and between Berthold and Willem I am optimistic that we’ll get this taken care of. No pressure, but having a rough estimate how long this might take would be helpful for me.

Jan I, Jan M, Berthold and I have been working on the prefs/setting situation which I think is getting to a stable point “any minute now".

I know that Linus is looking into the Garmin Descent Mk1 as BLE devices - it would be good to know if this is something that feels “close” or “not sure if this will ever work”

Jef and/or I need to figure out what to do about the Shearwater Teric. Mostly this is an issue of finding time, I guess :-)

Is there anything else that people have “about ready”?

/D
Post by Dirk Hohndel
I think we have a few potential issues that need to be resolved - the current disagreements over how to best handle settings, preferences, etc might cause us issues that I don't want to expose our user base to.
- Mac: include the FTDI driver and no longer require Mac FTDI drivers to be installed
- Desktop: allow buddies to be shown in the divelist [#1587]
- Windows: write log files to the user path instead of the path where Subsurface
is installed.
- Desktop: fix issue with dive list row height in case of larger fonts [#1600]
- Desktop: fix a bug where it is possible for the user to hide all divelist columns [#1600]
- Desktop/Export: fix bug related to quoted text when exporting to HTML [#1576]
- Desktop/Map-Widget: add support for filtering of map locations [#1581]
- Mac: fix problem downloading from divelogs.de <http://divelogs.de/>
- Dive media: paint duration of videos on thumbnails in the dive-photo tab
- Dive media: extract video thumbnails using ffmpeg
- Dive media: implement "open folder of selected media files" [#1514]
- Dive media: show play-time of videos on the profile plot
- Dive media: draw thumbnails on top of deco-ceilings
- Dive media: Change term "photos" and "images" everywhere in the UI to "media files"
- Dive media: experimental support for metadata extraction from AVI and WMV files
- Dive media: sort thumbnails by timestamp
- Dive media: don't recalculate all pictures on drag & drop
- Profile: immediately update thumbnail positions on deletion
I will push the latest strings to Transifex in a moment. But I expect that (as always) there might be a few more coming.
In the meantime I'd like to create a punch list of what we need to address before a release
- Settings/Preferences: make sure that we are in a sane state (purely from an end user perspective - let's not restart the arguments about the implementation here)
- Translations
- Documentation: any changes needed?
- reports of crashes - I tried to ping the people reporting those to get an update... if you can make Subsurface crash, please comment here
What else should be on this list?
/D
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Linus Torvalds
2018-09-07 22:11:25 UTC
Permalink
Post by Dirk Hohndel
I know that Linus is looking into the Garmin Descent Mk1 as BLE devices - it would
be good to know if this is something that feels “close” or “not sure if this will ever work”…
Oh, I think it's workable - I have a trace, I can connect to it, I see
the GATT descriptors - but it's not close.

You can definitely ignore Garmin BLE for this release, it would take
some unexpected sudden breakthrough for me to go from "I can see some
patterns in the trace" to "I can actually download data".

So realistically I'm weeks away, and that's not some guarantee either.
I'm really happy with how quickly the Garmin parser came together, and
we have that going for us, but plan on it being USB-only for the
immediate future.

Linus
Dirk Hohndel
2018-09-07 23:48:29 UTC
Permalink
Post by Linus Torvalds
So realistically I'm weeks away, and that's not some guarantee either.
I'm really happy with how quickly the Garmin parser came together, and
we have that going for us, but plan on it being USB-only for the
immediate future.
Thanks - that’s good to know for planning purposes.

In the meantime I have started working on the Shearwater Teric download, which
will also significantly change the download from most other Shearwater dive computer
(anything but Predator and /possibly/ the very oldest Petrels). I have all the docs I need,
I had dive computers to test with, all I need is the time to implement this and I think I
might be able to get this into testable state this weekend.

I know that Jef has also been planning to look into this, but haven’t seen anything from
him, so I hope I’m not duplicating work that already exists.

/D
Jef Driesen
2018-09-14 12:58:37 UTC
Permalink
Post by Dirk Hohndel
On Sep 7, 2018, at 3:11 PM, Linus Torvalds
So realistically I'm weeks away, and that's not some guarantee either.
I'm really happy with how quickly the Garmin parser came together, and
we have that going for us, but plan on it being USB-only for the
immediate future.
Thanks - that’s good to know for planning purposes.
In the meantime I have started working on the Shearwater Teric
download, which
will also significantly change the download from most other Shearwater dive computer
(anything but Predator and /possibly/ the very oldest Petrels). I have all the docs I need,
I had dive computers to test with, all I need is the time to implement this and I think I
might be able to get this into testable state this weekend.
I know that Jef has also been planning to look into this, but haven’t seen anything from
him, so I hope I’m not duplicating work that already exists.
Sorry for the late response. I've had some problems with internet access
lately, and the past few weeks I've also been fully occupied with some
other things in life. So I'm running a bit behind at the moment and I'll
have a lot to catch up with. But I probably won't have much time for
doing libdivecomputer related work until next month.

But the answer your question, I had not started working on the Teric
support yet.

Jef
Dirk Hohndel
2018-09-14 13:20:45 UTC
Permalink
Post by Dirk Hohndel
Post by Linus Torvalds
So realistically I'm weeks away, and that's not some guarantee either.
I'm really happy with how quickly the Garmin parser came together, and
we have that going for us, but plan on it being USB-only for the
immediate future.
Thanks - that’s good to know for planning purposes.
In the meantime I have started working on the Shearwater Teric download, which
will also significantly change the download from most other Shearwater dive computer
(anything but Predator and /possibly/ the very oldest Petrels). I have
all the docs I need,
I had dive computers to test with, all I need is the time to implement this and I think I
might be able to get this into testable state this weekend.
I know that Jef has also been planning to look into this, but haven’t
seen anything from
him, so I hope I’m not duplicating work that already exists.
Sorry for the late response. I've had some problems with internet access lately, and the past few weeks I've also been fully occupied with some other things in life. So I'm running a bit behind at the moment and I'll have a lot to catch up with. But I probably won't have much time for doing libdivecomputer related work until next month.
Life happens...
But the answer your question, I had not started working on the Teric support yet.
We have what I believe fairly complete Teric support in the Subsurface-NG branch of our libdivecomputer repo that is referenced in Subsurface master.
Feel free to look at / use. If you have comments or would like changes, please let me know - as you know I'd prefer to have our code as close to your upstream as possible.

/D
Dirk Hohndel
2018-09-14 16:40:30 UTC
Permalink
I’ve been a bit distracted with other stuff this week so I’m not as far as I wanted to be wrt being able to release 4.8.2

I don’t think I’ll get it ready this weekend, but I’ll try.
It would be good to collect things that need to get done before a release here if possible.

E.g., how are we doing with respect to the user manual changes proposed?
I’ll pull translations today - I think I’ve seen a lot of progress there, but I need to check if there are obvious gaps.
I started looking through the issues something like four times in the last few days and always immediately got side-tracked.

Any help and especially TESTING would be welcome.

And to state clearly what I hadn’t mentioned before - I also want to release a new Subsurface-mobile version so that Teric support is added on Mobile as well.

Thanks
Willem Ferguson
2018-09-14 18:01:10 UTC
Permalink
Post by Dirk Hohndel
I’ve been a bit distracted with other stuff this week so I’m not as far as I wanted to be wrt being able to release 4.8.2
I don’t think I’ll get it ready this weekend, but I’ll try.
It would be good to collect things that need to get done before a release here if possible.
E.g., how are we doing with respect to the user manual changes proposed?
Will be done by Sunday mid-day PDT. Will finish tomorrow & send to
Berthold for review.
Kind regards,
willem
Post by Dirk Hohndel
I’ll pull translations today - I think I’ve seen a lot of progress there, but I need to check if there are obvious gaps.
I started looking through the issues something like four times in the last few days and always immediately got side-tracked.
Any help and especially TESTING would be welcome.
And to state clearly what I hadn’t mentioned before - I also want to release a new Subsurface-mobile version so that Teric support is added on Mobile as well.
Thanks
_______________________________________________
subsurface mailing list
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full
details.
Pedro Neves
2018-09-14 18:05:47 UTC
Permalink
Post by Dirk Hohndel
I’ll pull translations today - I think I’ve seen a lot of progress
there, but I need to check if there are obvious gaps.
I started looking through the issues something like four times in the
last few days and always immediately got side-tracked.
Any help and especially TESTING would be welcome.
Dirk:

There seems to be a string missing for translation:

On the Export dialog, there's a new option "Anonymize" which doesn't
show up in Transifex...

Cheers:


Pedro
Dirk Hohndel
2018-09-14 18:20:34 UTC
Permalink
Post by Dirk Hohndel
I’ll pull translations today - I think I’ve seen a lot of progress there, but I need to check if there are obvious gaps.
I started looking through the issues something like four times in the last few days and always immediately got side-tracked.
Any help and especially TESTING would be welcome.
On the Export dialog, there's a new option "Anonymize" which doesn't show up in Transifex...
Thanks for the reminder… I’ll push out one more time.

/D
Pedro Neves
2018-09-15 18:21:59 UTC
Permalink
Thanks for the reminder
 I’ll push out one more time.
/D
Dirk:

2 more strings missing for translation. When right clicking on a dive:

1 - Load media from file(s)

2 - Load media from web


The first string shows up on Transifex, but I get a warning: "The
translation does not contain the same number of opening parentheses '('
as the original phrase". This is normal, as the PT translation needs
this additional parentheses. The second string doesn't show up at all...


Cheers:

Pedro
Dirk Hohndel
2018-09-17 15:48:45 UTC
Permalink
I need to stop procrastinating and start cutting the release or it will
never happen...

Hopefully at some point today :-)

Of course, by now I have forgotten everything about the tooling that I
designed to post draft announcements to Transifex. Grmbl.

/D
Dirk Hohndel
2018-09-17 17:06:19 UTC
Permalink
Post by Dirk Hohndel
Of course, by now I have forgotten everything about the tooling that I
designed to post draft announcements to Transifex. Grmbl.
For now I’m working only on the 4.8.2 announcement - just to stay sane.
I pushed it to Transifex and played with the user experience for the translators a bit. This is actually quite nice.
One note of caution. For strings 30-38 (the mostly boilerplate text about downloads) it’s easy to copy the suggestions as only the version number changed. But CAREFUL - the links (which are encoded as these numbered tags) also changed and you need to replace them with the correct links from the source string.
Thankfully you get yellow warning triangles if you don’t do that right, but it’s easy to overlook.

I of course appreciate all translations of the announcement but I won’t hold the announcement until all translations are in (I’ll simply updated them later).

(of course, a better maintainer would have posted this draft at least a week ago to give people time to translate, but whom are we kidding. We all know that I suck at this…)

Thanks for everyone’s help.

/D
Dirk Hohndel
2018-09-17 17:09:19 UTC
Permalink
Post by Dirk Hohndel
One note of caution. For strings 30-38 (the mostly boilerplate text about downloads) it’s easy to copy the suggestions as only the version number changed. But CAREFUL - the links (which are encoded as these numbered tags) also changed and you need to replace them with the correct links from the source string.
Thankfully you get yellow warning triangles if you don’t do that right, but it’s easy to overlook.
Oh, and since this is not 100% intuitive (IMHO), here’s how I did this:

- copy the suggestion
- update the version number
- delete the tags which have different numbers in them compared to the source
- position your cursor on the right spot in the translation and click on the tag in source string
- repeat for all missing tags

If you get too frustrated by it, simply ignore the tags and the yellow triangles, but send me an email asking me to fix this - I’m happy to do it for you.

Thanks again

/D
Salvador Cuñat
2018-09-17 19:36:26 UTC
Permalink
Post by Dirk Hohndel
Post by Dirk Hohndel
One note of caution. For strings 30-38 (the mostly boilerplate text about downloads) it’s easy to copy the suggestions as only the version number changed. But CAREFUL - the links (which are encoded as these numbered tags) also changed and you need to replace them with the correct links from the source string.
Thankfully you get yellow warning triangles if you don’t do that right, but it’s easy to overlook.
- copy the suggestion
- update the version number
- delete the tags which have different numbers in them compared to the source
- position your cursor on the right spot in the translation and click on the tag in source string
- repeat for all missing tags
Hmmm. It seems too complex.
I just copy the english text and overwrite the translatable parts.
This keeps the links and the html tags untouched.

Best regards.

Salva

Dirk Hohndel
2018-09-14 18:20:11 UTC
Permalink
Post by Dirk Hohndel
I’ve been a bit distracted with other stuff this week so I’m not as far as I wanted to be wrt being able to release 4.8.2
I don’t think I’ll get it ready this weekend, but I’ll try.
It would be good to collect things that need to get done before a release here if possible.
E.g., how are we doing with respect to the user manual changes proposed?
Will be done by Sunday mid-day PDT. Will finish tomorrow & send to Berthold for review.
Excellent. Thanks

/D
Loading...