Discussion:
Robert, Stefan, Dive mode problems
Willem Ferguson
2018-06-01 08:34:03 UTC
Permalink
Attached are the xml dive  header and dive computer description of a
pSCR dive, as well as the UI rendering of the dive profile. Obviously
there there are significant differences between the xml and the graphic
derived from that dive log. The two most obvious discrepancies are:

1) In the UI, the dive computer is indicated as OC (see lefthand of
screenshot). However, in the xml dive log it is indicated as PSCR.

2) The xml event at 10 min 14 sec into the dive is a divemode transition
from OC to PSCR. However, on the dive profile it is indicated as
transition from PSCR to OC.

Now, the very real possibility exists that this results from Ferguson's
own doings and code changes by him. However after all the bailout
changes were performed the rendering of divemode changes worked
perfectly. The latest changes pertain to the dive planner and code in
planner.c, not affecting the dive log.

The obvious suspect are the changes to the names of divemodes,
separating the displayed names from the internal divemode names.

Robert, Stefan, would it be possible to have a quick check to see if
there is an obvious bug?

Kind regards,

willem
--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf
<http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf> for
full
details.
Stefan Fuchs
2018-06-16 15:48:00 UTC
Permalink
Hello Willem, hallo Robert,
Post by Willem Ferguson
Attached are the xml dive  header and dive computer description of a
pSCR dive, as well as the UI rendering of the dive profile. Obviously
there there are significant differences between the xml and the
graphic derived from that dive log. The two most obvious discrepancies
1) In the UI, the dive computer is indicated as OC (see lefthand of
screenshot). However, in the xml dive log it is indicated as PSCR.
2) The xml event at 10 min 14 sec into the dive is a divemode
transition from OC to PSCR. However, on the dive profile it is
indicated as transition from PSCR to OC.
Now, the very real possibility exists that this results from
Ferguson's own doings and code changes by him. However after all the
bailout changes were performed the rendering of divemode changes
worked perfectly. The latest changes pertain to the dive planner and
code in planner.c, not affecting the dive log.
The obvious suspect are the changes to the names of divemodes,
separating the displayed names from the internal divemode names.
Robert, Stefan, would it be possible to have a quick check to see if
there is an obvious bug?
Sorry for not joining the discussion for such a long time.

I guess the issue described above was meanwhile fixed by Robert, wasn't it?

Best regards
Stefan
--
Stefan Fuchs
E-Mail: ***@gmx.de <mailto:***@gmx.de>
Robert Helling
2018-06-16 19:48:40 UTC
Permalink
Post by Stefan Fuchs
Sorry for not joining the discussion for such a long time.
Sorry, this got lost in my inbox. I should be able to look into this very soon.

Best
Robert
Stefan Fuchs
2018-06-17 07:19:28 UTC
Permalink
Hello Robert, hello Willem,
Post by Robert Helling
Post by Stefan Fuchs
Sorry for not joining the discussion for such a long time.
Sorry, this got lost in my inbox. I should be able to look into this very soon.
Willem confirmed that this got fixed. I guess here:
https://github.com/Subsurface-divelog/subsurface/commit/780530f32ec8aa691916b839a96d8863e8dceb66

But while testing I found another bug in current master around the dive
modes:
If you replan a dive with multiple dive planner points with different
dive modes, the dive modes are not re-loaded into the dive planner
points again.

Best regards
Stefan
--
Stefan Fuchs
E-Mail: ***@gmx.de <mailto:***@gmx.de>
Robert C. Helling
2018-06-17 07:20:54 UTC
Permalink
Stefan,
Post by Stefan Fuchs
Hello Robert, hello Willem,
Post by Robert Helling
Post by Stefan Fuchs
Sorry for not joining the discussion for such a long time.
Sorry, this got lost in my inbox. I should be able to look into this very soon.
https://github.com/Subsurface-divelog/subsurface/commit/780530f32ec8aa691916b839a96d8863e8dceb66
If you replan a dive with multiple dive planner points with different dive modes, the dive modes are not re-loaded into the dive planner points again.
Best regards
Stefan
--
Stefan Fuchs
Good catch. Added to my todo list.

Robert
Robert Helling
2018-06-19 12:58:38 UTC
Permalink
Willem,
Robert, Stefan, would it be possible to have a quick check to see if there is an obvious bug?
I just wanted to look into this but realised you only sent the upper part of the xml file. This makes it very hard to debug this problem. Please feel free to email it off list (just this dive).

Thanks
Robert

Loading...