rush job before I travel - can we pull off 4.8.3 / 2.1.4 this weekend?

[Dirk Hohndel]

A rather embarrassing bug in my Shearwater Teric code, Linus' awesome work on Mares BlueLink Pro support,
The improvements to the mobile UI. The dive computer shortcut buttons.

Yes, it's a bit of a rush job. But I'm wondering if we could do this.

Thoughts?

/D

[Jan Mulder]

Post by Dirk Hohndel
A rather embarrassing bug in my Shearwater Teric code, Linus' awesome work on Mares BlueLink Pro support,
The improvements to the mobile UI. The dive computer shortcut buttons.
Yes, it's a bit of a rush job. But I'm wondering if we could do this.
Thoughts?

With respect to the mobile UI: ACK for a 2.1.4

Just push the strings to Transifex to get things translated.

--jan

[Dirk Hohndel]

Post by Jan Mulder

Post by Dirk Hohndel
A rather embarrassing bug in my Shearwater Teric code, Linus' awesome work on Mares BlueLink Pro support,
The improvements to the mobile UI. The dive computer shortcut buttons.
Yes, it's a bit of a rush job. But I'm wondering if we could do this.
Thoughts?

With respect to the mobile UI: ACK for a 2.1.4
Just push the strings to Transifex to get things translated.

Done

/D

[Jan Mulder]

Post by Jan Mulder

Post by Dirk Hohndel
A rather embarrassing bug in my Shearwater Teric code, Linus' awesome work on Mares BlueLink Pro support,
The improvements to the mobile UI. The dive computer shortcut buttons.
Yes, it's a bit of a rush job. But I'm wondering if we could do this.
Thoughts?

With respect to the mobile UI: ACK for a 2.1.4
Just push the strings to Transifex to get things translated.

Done

Ok, NL translation is also done.

BUT: my optimistic view on the mobile UI was wrong. Just found a
(massive) bug in the new Kirigami. Just verified this by reverting
commit 17ec95e70c3ae58 (to get back to the previous SHA).

So needed: revert both 17ec95e70c3ae58 and 40766db459b21.

Bug is related to the page stack and swiping through dives and returning
to the list by the breadcrumb (instead of the menu). Sometimes this
results in a page that shows both the divelist and the divedetail page
on top of each other. Easy to get to a sane state again from that (just
select the dive list from the menu), so not a real showstopper, but it
look ugly.

--jan

[Dirk Hohndel]

Post by Jan Mulder

Post by Jan Mulder

Post by Dirk Hohndel
A rather embarrassing bug in my Shearwater Teric code, Linus' awesome work on Mares BlueLink Pro support,
The improvements to the mobile UI. The dive computer shortcut buttons.
Yes, it's a bit of a rush job. But I'm wondering if we could do this.
Thoughts?

With respect to the mobile UI: ACK for a 2.1.4
Just push the strings to Transifex to get things translated.

Done

Ok, NL translation is also done.
BUT: my optimistic view on the mobile UI was wrong. Just found a (massive) bug in the new Kirigami. Just verified this by reverting commit 17ec95e70c3ae58 (to get back to the previous SHA).
So needed: revert both 17ec95e70c3ae58 and 40766db459b21.
Bug is related to the page stack and swiping through dives and returning to the list by the breadcrumb (instead of the menu). Sometimes this results in a page that shows both the divelist and the divedetail page on top of each other. Easy to get to a sane state again from that (just select the dive list from the menu), so not a real showstopper, but it look ugly.

UGH.

Ok, reverting those two. I got side-tracked with work and real life but I’m hoping to have reviewed what we have committed since 4.8.2 / 2.1.3 so I can have reasonable test build for everyone to play with tonight.

/D

[Dirk Hohndel]

Here’s where we are:

Test binaries are app for all platforms:
Windows: http://subsurface-divelog.org/downloads/test/subsurface-4.8.2-90-ge0e20edd87af.exe
Mac: http://subsurface-divelog.org/downloads/test/Subsurface-4.8.2-90-ge0e20edd87af.dmg
AppImage: https://github.com/Subsurface-divelog/subsurface/releases/download/continuous/Subsurface-4.8.2-90-ge0e20edd87af-x86_64.AppImage
Ubuntu is on Launchpad
OpenSUSE is on OBS
Fedora builds failed again on OBS, need to look into what I messed up this time - it looks like my fix for the appdata.xml didn’t actually work
Android: http://subsurface-divelog.org/downloads/test/Subsurface-mobile-4.8.2.90-arm.apk - but also pushed to Google Play beta channel
iOS has been submitted for review, should show up “soon”

It would be great to make sure we have at least some testing for these binaries - reports “hey, did a quick test, nothing seems broken” (or the opposite :-( ) would be extremely helpful so that we at least have some indication how much testing this has gotten.

Many translations have already been completed - you people are AMAZING!!!

If all goes well I’ll create this “quick release” on Saturday :-)

Thanks

/D

Post by Jan Mulder

Post by Jan Mulder

Post by Dirk Hohndel
A rather embarrassing bug in my Shearwater Teric code, Linus' awesome work on Mares BlueLink Pro support,
The improvements to the mobile UI. The dive computer shortcut buttons.
Yes, it's a bit of a rush job. But I'm wondering if we could do this.
Thoughts?

With respect to the mobile UI: ACK for a 2.1.4
Just push the strings to Transifex to get things translated.

Done

Ok, NL translation is also done.
BUT: my optimistic view on the mobile UI was wrong. Just found a (massive) bug in the new Kirigami. Just verified this by reverting commit 17ec95e70c3ae58 (to get back to the previous SHA).
So needed: revert both 17ec95e70c3ae58 and 40766db459b21.
Bug is related to the page stack and swiping through dives and returning to the list by the breadcrumb (instead of the menu). Sometimes this results in a page that shows both the divelist and the divedetail page on top of each other. Easy to get to a sane state again from that (just select the dive list from the menu), so not a real showstopper, but it look ugly.

UGH.
Ok, reverting those two. I got side-tracked with work and real life but I’m hoping to have reviewed what we have committed since 4.8.2 / 2.1.3 so I can have reasonable test build for everyone to play with tonight.
/D

[Jan Mulder]

Post by Dirk Hohndel
http://subsurface-divelog.org/downloads/test/subsurface-4.8.2-90-ge0e20edd87af.exe
http://subsurface-divelog.org/downloads/test/Subsurface-4.8.2-90-ge0e20edd87af.dmg
https://github.com/Subsurface-divelog/subsurface/releases/download/continuous/Subsurface-4.8.2-90-ge0e20edd87af-x86_64.AppImage
Ubuntu is on Launchpad
OpenSUSE is on OBS
Fedora builds failed again on OBS, need to look into what I messed up
this time - it looks like my fix for the appdata.xml didn’t actually work
http://subsurface-divelog.org/downloads/test/Subsurface-mobile-4.8.2.90-arm.apk
- but also pushed to Google Play beta channel
iOS has been submitted for review, should show up “soon”
It would be great to make sure we have at least some testing for these
binaries - reports “hey, did a quick test, nothing seems broken” (or the
opposite :-( ) would be extremely helpful so that we at least have some
indication how much testing this has gotten.
Many translations have already been completed - you people are AMAZING!!!
If all goes well I’ll create this “quick release” on Saturday :-)

Android from play store tested. Swiping through logbook, OSTC download
over BT and BLE, scaling UI => all good :-)

--jan