Cloud storage does not load at startup since b9b1f03

[Gaetan Bisson]

Hi Jan,

I run a build of Subsurface's latest git master but since b9b1f03 I find
that cloud storage does not load upon startup as it used to.

Is there any settings or such things I need to migrate to conform with
the new qPrefCloudStorage?

Cheers.

[Jan Iversen]

Hi

I do not know of any specific variables (except in mobile, you need to say you want to sync automatically). qPrefCloudStorage should not change that behavior, however I will try and debug around that.

I assume you talk about the desktop version ?

rgds
jan i

Enviado desde mi iPad

Post by Gaetan Bisson
Hi Jan,
I run a build of Subsurface's latest git master but since b9b1f03 I find
that cloud storage does not load upon startup as it used to.
Is there any settings or such things I need to migrate to conform with
the new qPrefCloudStorage?
Cheers.
--
Gaetan

[Jan Iversen]

Hi Gaetan

I am confused, I have now compiled a number of commits before the qPrefCloudStorage commit, and finally I compiled b2422f885 (tagged v4.8.1) and none of them opens the cloudstorage automatically.

I am on a virtual mac, high sierra 10.13, and I cannot rule out that e.g. qPrefCloudStorage ruined some settings, but it does seem odd, so maybe somebody else can confirm the problem.

I will see if I can make a fresh install, to secure against corrupted settings.

rgds
jan i

Enviado desde mi iPad

Post by Gaetan Bisson
Hi Jan,
I run a build of Subsurface's latest git master but since b9b1f03 I find
that cloud storage does not load upon startup as it used to.
Is there any settings or such things I need to migrate to conform with
the new qPrefCloudStorage?
Cheers.
--
Gaetan

[Jan Iversen]

I was finally able to confirm the problem.

I used a local xml profile and that prohibits cloud automatic loading, with a cloud based default xml, I can reproduce the problem, which is somewhere in qPrefCloudStorage.

Sorry for the multiple mails, but this one was not intuitive to confirm. I still have to understand why using a local profile stops automatic loading.

I am on debugging and hope to have a PR ready very soon.

Thanks for making me aware of the problem.
rgds
jan I

Enviado desde mi iPad

Post by Gaetan Bisson
Hi Jan,
I run a build of Subsurface's latest git master but since b9b1f03 I find
that cloud storage does not load upon startup as it used to.
Is there any settings or such things I need to migrate to conform with
the new qPrefCloudStorage?
Cheers.
--
Gaetan

[Gaetan Bisson]

Post by Jan Iversen
I was finally able to confirm the problem.
I used a local xml profile and that prohibits cloud automatic loading, with a cloud based default xml, I can reproduce the problem, which is somewhere in qPrefCloudStorage.
Sorry for the multiple mails, but this one was not intuitive to confirm. I still have to understand why using a local profile stops automatic loading.
I am on debugging and hope to have a PR ready very soon.

Thanks so much for looking into this, Jan.

And sorry for my lack of response to your other messages: I sent my
email yesterday evening quite tired after a day of diving and went
straight to bed afterwards... :)

Cheers.

[Stefan Fuchs]

Hallo Jan,

Post by Jan Iversen
I was finally able to confirm the problem.
I used a local xml profile and that prohibits cloud automatic loading, with a cloud based default xml, I can reproduce the problem, which is somewhere in qPrefCloudStorage.
Sorry for the multiple mails, but this one was not intuitive to confirm. I still have to understand why using a local profile stops automatic loading.
I am on debugging and hope to have a PR ready very soon.
Thanks for making me aware of the problem.
rgds
jan I
Enviado desde mi iPad

Post by Gaetan Bisson
Hi Jan,
I run a build of Subsurface's latest git master but since b9b1f03 I find
that cloud storage does not load upon startup as it used to.
Is there any settings or such things I need to migrate to conform with
the new qPrefCloudStorage?
Cheers.
--
Gaetan

I also have to report some unintended behavior coming from the
"qPrefCloudStorage" change.
My setup is the following:
I by default start Subsurface with a local .xml file ("Stefan.xml") and
rather seldom use the cloud storage.

After the change Subsurface starts with a title bar showing "[Cloud
storage for] Stefan.xml" which is obviously not correct because I want
to have the local file. Also the menu entry "File->Cloud storage online"
is active which is also incorrect. I have the feeling that also the
overall behavior regarding which data is used is rather strange but
that's just a guess.


Best regards
Stefan

[Dirk Hohndel]

I also have to report some unintended behavior coming from the "qPrefCloudStorage" change.
I by default start Subsurface with a local .xml file ("Stefan.xml") and rather seldom use the cloud storage.
After the change Subsurface starts with a title bar showing "[Cloud storage for] Stefan.xml" which is obviously not correct because I want to have the local file. Also the menu entry "File->Cloud storage online" is active which is also incorrect. I have the feeling that also the overall behavior regarding which data is used is rather strange but that's just a guess.

My quick test here with a couple of scenarios seems to indicate that we misinterpret the setting for what to do at startup. Haven't had spent enough time staring at the code to understand why.

This is always the risk with rewrites like this (and why Tomaz was not excited to see another rewrite of the preferences subsystem, given that he had done this before and felt the existing system was good enough...) but now that we started, we should track down the little bugs but otherwise finish things.

/D

[Jan Iversen]

Thanks to everybody for reporting issues, it is my top priority to solve these issues.

Stefan: can you please confirm that your problems is when using the desktop ? and before qCloudStorage it would load your local cache?

I just had a look at my jani.xml it has a lot of empty settings, can someone (stefan?) please send me in private a filled xml working file, so I can adapt it to my xml file. THANKS IN ADVANCE.

ItÂŽs late here, but I will continue working tomorrow (after my training lessons).

Dirk: you write “a couple of scenarios” if that is more than the 2 I pursue now (cloud not loading automatically with cloud profile, and local profile tries to load from cloud) please be so kind and detail them so I can reproduce them.

Thanks to all for showing patience while I solve the problem I introduced.

rgds
jan I.



Enviado desde mi iPad

Post by Dirk Hohndel

I also have to report some unintended behavior coming from the "qPrefCloudStorage" change.
I by default start Subsurface with a local .xml file ("Stefan.xml") and rather seldom use the cloud storage.
After the change Subsurface starts with a title bar showing "[Cloud storage for] Stefan.xml" which is obviously not correct because I want to have the local file. Also the menu entry "File->Cloud storage online" is active which is also incorrect. I have the feeling that also the overall behavior regarding which data is used is rather strange but that's just a guess.

My quick test here with a couple of scenarios seems to indicate that we misinterpret the setting for what to do at startup. Haven't had spent enough time staring at the code to understand why.
This is always the risk with rewrites like this (and why Tomaz was not excited to see another rewrite of the preferences subsystem, given that he had done this before and felt the existing system was good enough...) but now that we started, we should track down the little bugs but otherwise finish things.
/D

[Gaetan Bisson]

Hi Jan,

Just another remark (and I hope you can reproduce this): my issue is not
limited to auto loading cloud storage on startup; even if I manually
click on "File -> Open cloud storage" then nothing happens and the dive
list remains empty.

Loading XML files work and reverting to any commit before b9b1f03 fixes
the cloud storage issue.

Cheers.

[Jan Iversen]

Enviado desde mi iPad

Post by Gaetan Bisson
Hi Jan,
Just another remark (and I hope you can reproduce this): my issue is not
limited to auto loading cloud storage on startup; even if I manually
click on "File -> Open cloud storage" then nothing happens and the dive
list remains empty.

Now this is strange, that works here. I use “cloud xml file”, and when I click “File -> Open Cloud storage” I get all my dives (except that sometimes the cloud connection runs into a timeout).

Could you please mail me your log file (from a simple startup, and click on “open cloud storage”) so I can compare. Thanks in advance.

Post by Gaetan Bisson
Loading XML files work and reverting to any commit before b9b1f03 fixes
the cloud storage issue.

I think I have found a chicken-egg problem and my PR reversed the order, but I need to test more.

have a nice day
rgds
jan I

Post by Gaetan Bisson
Cheers.
--
Gaetan

[Gaetan Bisson]

Now this is strange, that works here. I use “cloud xml file”, and when I click “File -> Open Cloud storage” I get all my dives (except that sometimes the cloud connection runs into a timeout).

I'm using "Cloud storage default file" under "Preferences -> General ->
Dives" if that's what you mean. I'm attaching my Subsurface.conf
redacted only for the password under the CloudStorage section, as well
as screenshots of the relevant configuration panels.

Could you please mail me your log file (from a simple startup, and click on “open cloud storage”) so I can compare. Thanks in advance.

Do you mean what `subsurface -v` sends out to standard output/error? See
the file attached. I can also send you my cloud storage logbook exported
as XML file if that's what you meant but I doubt it'll be as useful.

Cheers.

[Jan Iversen]

Thanks you sent me exactly what I was looking, sorry for not being precise (I write in between changing bottles at the compressor).

rgds
jan i

Enviado desde mi iPad

Post by Gaetan Bisson

Post by Jan Iversen
Now this is strange, that works here. I use “cloud xml file”, and when I click “File -> Open Cloud storage” I get all my dives (except that sometimes the cloud connection runs into a timeout).

I'm using "Cloud storage default file" under "Preferences -> General ->
Dives" if that's what you mean. I'm attaching my Subsurface.conf
redacted only for the password under the CloudStorage section, as well
as screenshots of the relevant configuration panels.

Post by Jan Iversen
Could you please mail me your log file (from a simple startup, and click on “open cloud storage”) so I can compare. Thanks in advance.

Do you mean what `subsurface -v` sends out to standard output/error? See
the file attached. I can also send you my cloud storage logbook exported
as XML file if that's what you meant but I doubt it'll be as useful.
Cheers.
--
Gaetan
<bla0.png>
<bla1.png>
<Subsurface.conf>
<stdout.txt>

[Jan Iversen]

Hi

Master was just updated with my fix, I hope that solves your problem.

rgds
jan i

Enviado desde mi iPad

Post by Jan Iversen
Thanks you sent me exactly what I was looking, sorry for not being precise (I write in between changing bottles at the compressor).
rgds
jan i
Enviado desde mi iPad

Post by Gaetan Bisson

Post by Jan Iversen
Now this is strange, that works here. I use “cloud xml file”, and when I click “File -> Open Cloud storage” I get all my dives (except that sometimes the cloud connection runs into a timeout).

I'm using "Cloud storage default file" under "Preferences -> General ->
Dives" if that's what you mean. I'm attaching my Subsurface.conf
redacted only for the password under the CloudStorage section, as well
as screenshots of the relevant configuration panels.

Post by Jan Iversen
Could you please mail me your log file (from a simple startup, and click on “open cloud storage”) so I can compare. Thanks in advance.

Do you mean what `subsurface -v` sends out to standard output/error? See
the file attached. I can also send you my cloud storage logbook exported
as XML file if that's what you meant but I doubt it'll be as useful.
Cheers.
--
Gaetan
<bla0.png>
<bla1.png>
<Subsurface.conf>
<stdout.txt>

[Gaetan Bisson]

Post by Jan Iversen
Master was just updated with my fix, I hope that solves your problem.

Thanks Jan, this indeed fixes my problem. Cheers.